Prefer use of deepErrorX over undefined

clash-lang · Oct 18, 2024 · a90007a · a90007a
1 parent f58812c
commit a90007a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/clash-protocols/src/Protocols/PacketStream/Base.hs b/clash-protocols/src/Protocols/PacketStream/Base.hs
@@ -166,15 +166,21 @@ instance DfConv.DfConv (PacketStream dom dataWidth meta) where
   toDfCircuit _ = fromSignals go
    where
     go (fwdIn, bwdIn) =
-      ( (fmap coerce bwdIn, pure undefined)
+      (
+        ( fmap coerce bwdIn
+        , pure (deepErrorX "PacketStream toDfCircuit: undefined")
+        )
       , Df.dataToMaybe <$> P.fst fwdIn
       )
 
   fromDfCircuit _ = fromSignals go
    where
     go (fwdIn, bwdIn) =
       ( coerce <$> P.fst bwdIn
-      , (fmap Df.maybeToData fwdIn, pure undefined)
+      ,
+        ( fmap Df.maybeToData fwdIn
+        , pure (deepErrorX "PacketStream fromDfCircuit: undefined")
+        )
       )
 
 instance

diff --git a/clash-protocols/src/Protocols/PacketStream/Depacketizers.hs b/clash-protocols/src/Protocols/PacketStream/Depacketizers.hs
@@ -94,7 +94,7 @@ instance
   Default (DepacketizerState headerBytes dataWidth)
   where
   def :: DepacketizerState headerBytes dataWidth
-  def = Parse False (repeat undefined) maxBound
+  def = Parse False (deepErrorX "depacketizerT: undefined intial buffer") maxBound
 
 -- | Depacketizer state transition function.
 depacketizerT ::
@@ -270,7 +270,7 @@ instance
   Default (DfDepacketizerState headerBytes dataWidth)
   where
   def :: DfDepacketizerState headerBytes dataWidth
-  def = DfParse False (repeat undefined) maxBound
+  def = DfParse False (deepErrorX "depacketizeToDfT: undefined intial buffer") maxBound
 
 -- | Df depacketizer transition function.
 depacketizeToDfT ::