True Anonymous Posting for privacy and Tag specific anonymous options [WIP]

[Yippy]

Hiya, I'm not sure if this would be helpful in the extension, but the situation is to allow users to anonymously provide question without any link to them personally. This can be useful for suggestion boxes for teams/company, I've used your avatar rule table example to help create this imposter settings on your extension.

This setting will not interfere with your avatar anonymous, but it will compliment it if people truly don't wish to know who posted. The imposter user profile work best with the tag extension enable, where you can use any user profile to make a discussion or reply to the post.

Here is an example of someone making a suggestion:

When responding to the discussion, you can have another user profile to respond,

To-do:

• Allow multiple tags detection for discussion and post making, currently it will only check the first tag that is available.

• Fix "The requested resource was not found." where 404 Not Found error is provided for 'Non Approved' or 'Non related' post that is created when using this with Approval extension.
  

• Customise the post avatar url image when the tag is already pre-defined when using with composer with default tag for usage with 'flarum-ext-composer-page'.
  Note: this works with selecting the tags in the Compose page too.

• Fix Original discussion user when multiple poster make a post
  

• Fix issue for detecting admin that can turn off anonymous override switch

• Check if Tag extension is enabled, otherwise tags property does not exist

I'm fairly new on Flarum platform, but wanted to help improve it. If you have any tips on my to-do list. Just let me know, or any changes to help improve my code.

[clarkwinkelmann]

Thanks for your contribution. I fear this might be a bit too complex to maintain for me, so this could be better as a completely new extension. I probably won't be merging this, but I can reconsider when it's finished.

Here are some comments from reading the code:

• You cannot trust Arr::get($event->data, 'type'), users can provide anything or nothing at all and Flarum ignores the value anyway
• class_exists(Tag::class) will only tell you the Tags extension is installed, not enabled. When you call $discussion->tags the code will error if the extension is not enabled
• An event listener callback doesn't need to return $event;, just return;.

[Yippy]

Working example of private viewing post when using a imposter User account to post anonymously, though you need to wait for flarum to improve visibility for locked/private discussion and post.

Requires the following changes:
flarum/core
flarum/framework#3596
My fork Yippy/flarum-core@7cf86dc

flarum/approval
My fork
Yippy/flarum-core@7cf86dc
https://github.com/Yippy/approval/tree/60efa0e7f199c410ca46e14c626a0a7d25d8a4a3

It be nice if there was more control on the privacy options where you can hide locked/private from the discussion list but allow users/members to see the discussion and post when they get redirected/or copied the link.

Amend the composer.json to test this PR with this:

    "require": {
        "clarkwinkelmann/flarum-ext-anonymous-posting": "dev-custom",
        "flarum/approval": "dev-fix-view",
        "flarum/core": "dev-fixprivateview as v1.8.5",
    },
    "repositories": [
        {
             "type": "vcs",
             "url": "https://github.com/Yippy/flarum-ext-anonymous-posting"
        },
        {
             "type": "vcs",
             "url": "https://github.com/Yippy/flarum-core"
        },
        {
            "type": "vcs",
            "url": "https://github.com/Yippy/approval"
        }
    ],

[Yippy]

Three anonymous options for specific tags

1. '1+' Entering a valid User ID above 0 will choose an imposter account, non found User account will use default semi-anonymous.
2. '0' Zero will use the default semi-Anonymous option where Moderators can see poster.
3. '-1' Negative value will disable anonymous option

Here is an example of tag detections with different anonymous options, the tag 'Share' is set as -1 to allow users to post with their own profile without any anonymous options.

[Yippy]

@clarkwinkelmann How would I check if the extension has been enabled?

Fixed Avatar preview for imposter user for specific tag.