Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New errors in Jupyter Notebook #412

Merged
merged 2 commits into from
Sep 10, 2024
Merged

New errors in Jupyter Notebook #412

merged 2 commits into from
Sep 10, 2024

Conversation

groadabike
Copy link
Contributor

closes #411

@groadabike
fix ruff reported errors
7e9a5bd 
Signed-off-by: Gerardo Roa <[email protected]>
@groadabike groadabike linked an issue Sep 10, 2024 that may be closed by this pull request
pre-commit errors with notebooks #411
Closed
jonbarker68
jonbarker68 reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jonbarker68 jonbarker68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this should be OK now. Checked with ruff 0.6 locally and it's not finding any further problems.

@jonbarker68 jonbarker68 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit c8d4a22 Sep 10, 2024
6 checks passed
@groadabike
Copy link
Contributor Author

Yeah, perhaps the issue was that in this 3 weeks, pre-commit updated the version of ruff from 0.6.1 to 0.6.4, one version per week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbarker68 jonbarker68 jonbarker68 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit errors with notebooks
2 participants
@groadabike @jonbarker68