Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(help): Display value terminator and delimiter in help #5817

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Aethelflaed
Copy link

Display value terminator and delimiter in the command usage and help.

I added explicitly [value delimiter: ':'] and [value terminator: ";"] to the help message.

Closes #5392 and #4812.

Related to #1052

@Aethelflaed Aethelflaed force-pushed the display-value-delimiter-and-terminator-in-help branch from 6ba54e3 to c2dbb1b Compare November 14, 2024 15:47
@epage
Copy link
Member

epage commented Nov 14, 2024

From our contributor docs

Issues work well discussing a need and how to solve it

  • Focus: requirements gathering and design discussions
    Sometimes a branch or Draft PR might be used to demonstrate an idea

PRs work well for when the solution has already been discussed as an Issue or there is little to no discussion (obvious bug or documentation fixes)

  • Focus: implementation discussions

In particular, solutions were being discussed in #4812 and that was a suggested starting point for #5392. I see that was included but then more was done. That should be discussed before we get to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[arg(value_delimiter = ':')] Delimiter isnt displayed in the help message.
2 participants