fix(parser): Fill in defaults on ignored error

This came up in #5812 and is especially problematic for derives.
clap-rs · Nov 12, 2024 · 67e7574 · 67e7574
1 parent 026f188
commit 67e7574
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/clap_builder/src/parser/parser.rs b/clap_builder/src/parser/parser.rs
@@ -54,13 +54,14 @@ impl<'cmd> Parser<'cmd> {
     ) -> ClapResult<()> {
         debug!("Parser::get_matches_with");
 
-        ok!(self.parse(matcher, raw_args, args_cursor));
+        let res = self.parse(matcher, raw_args, args_cursor);
 
         ok!(self.resolve_pending(matcher));
         #[cfg(feature = "env")]
         ok!(self.add_env(matcher));
         ok!(self.add_defaults(matcher));
 
+        res?;
         Validator::new(self.cmd).validate(matcher)
     }
 

diff --git a/tests/builder/ignore_errors.rs b/tests/builder/ignore_errors.rs
@@ -113,7 +113,7 @@ fn unexpected_argument() {
         m.get_one::<String>("config").cloned(),
         Some("config file".to_owned())
     );
-    assert_eq!(m.get_one::<bool>("unset-flag").copied(), None);
+    assert_eq!(m.get_one::<bool>("unset-flag").copied(), Some(false));
 }
 
 #[test]