-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Github workflow for creating an unstable release #748
Conversation
This is a first step towards #517. So far the action is manually triggered, but we could consider expanding this in a future change to a regularly scheduled snapshot release, similar to what the clangd server has. |
Example of the workflow running successfully in my fork: https://github.com/HighCommander4/vscode-clangd/releases/tag/snapshot_20241205 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is useful to have this unstable release, it helps prevent rolling out a bad release to users.
run: npm run package | ||
- name: rename | ||
run: mv vscode-clangd-${{ steps.version.outputs.current-version }}.vsix | ||
vscode-clangd-unstable-${{ steps.version.outputs.current-version }}.vsix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to make a frequent unstable release (like per commit), I think it would be clearer to use the commit in the name, rather than use the current release version in the package.json (not sure this is possible to get the commit in workflow.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I updated the action to do this.
The workflow is manually triggered, and creates a Github release containing a build from the master branch.
8cf158c
to
e0eb417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my side.
The workflow is manually triggered, and creates a Github release containing a build from the master branch.