Follow-up cleanups after #728

[HighCommander4]

• The disposables passed in to install.activate() were not saved for cleanup
• config.get() is not async

[HighCommander4]

@thegecko or @JVApen perhaps you could have a brief look at this? (once again, I can't actually add you to "Reviewers")

[JVApen]

@HighCommander4 Can you keep the arguments as constructor parameter, see also my PR. Beside that, it looks good to me. I am however no expert in Javascript/Typescript

[HighCommander4]

@HighCommander4 Can you keep the arguments as constructor parameter, see also my PR.

Not sure why being a constructor parameter helps; you can always make it a local variable in the constructor.

[JVApen]

@HighCommander4 Can you keep the arguments as constructor parameter, see also my PR.

Not sure why being a constructor parameter helps; you can always make it a local variable in the constructor.

It feels more consistent to have all config arguments being provided via the constructor. Alternatively, I retrieve both arguments that I need in the constructor itself.

Up to you to decide.

[HighCommander4]

Alternatively, I retrieve both arguments that I need in the constructor itself.

Yeah, that's the direction this patch is trying to move towards: make all config.get calls in the constructor itself.

The only thing remaining outside the constructor is the install.activate call which cannot be moved into the constructor because it's async, and you can't use await in a constructor.

[HighCommander4]

Rebased on top of #730, which took care of the second part (not await-ing config.get).