[#681] re-enable file watcher #688
Conversation
package.json
Outdated
| @@ -144,7 +144,7 @@ | |||
| "clangd.onConfigChanged": { | |||
| "type": "string", | |||
| "default": "prompt", | |||
There was a problem hiding this comment.
Not sure if to put prompt or ignore as default behavior
| @@ -21,9 +21,7 @@ class ConfigFileWatcherFeature implements vscodelc.StaticFeature { | |||
|
|
|||
| initialize(capabilities: vscodelc.ServerCapabilities, | |||
| _documentSelector: vscodelc.DocumentSelector|undefined) { | |||
| if ((capabilities as ClangdClientCapabilities) | |||
| .compilationDatabase?.automaticReload) | |||
There was a problem hiding this comment.
I'd like us to keep respecting the server's automaticReload capability by default.
I was thinking of adding a new config option, like clangd.onConfigChanged.forceEnable: true, and only skipping this automaticReload check if that option is enabled.
There was a problem hiding this comment.
I've added "onConfigChangedForceEnable" option
(I tried "onConfigChanged.forceEnable" instead of "onConfigChangedForceEnable" but
config.get("onConfigChanged.forceEnable") fails, it doesnt seem to work when fields have "." in it
Any idea?)
There was a problem hiding this comment.
onConfigChanged.forceEnable works fine for me during local testing, and the documentation of the relevant vscode API says that it supports dotted names.
Could you try again, and if it doesn't work for you then post the version you're trying for further investigation?
| @@ -21,9 +21,7 @@ class ConfigFileWatcherFeature implements vscodelc.StaticFeature { | |||
|
|
|||
| initialize(capabilities: vscodelc.ServerCapabilities, | |||
| _documentSelector: vscodelc.DocumentSelector|undefined) { | |||
| if ((capabilities as ClangdClientCapabilities) | |||
| .compilationDatabase?.automaticReload) | |||
There was a problem hiding this comment.
onConfigChanged.forceEnable works fine for me during local testing, and the documentation of the relevant vscode API says that it supports dotted names.
Could you try again, and if it doesn't work for you then post the version you're trying for further investigation?
| "clangd.onConfigChangedForceEnable": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "Force enable of \"On Config Changed\" option regardless of clangd version." |
There was a problem hiding this comment.
Please also amend the description of onConfigChanged to read:
What to do when clangd configuration files are changed. Ignored for clangd 12+, which can reload such files itself; however, this can be overridden with clangd.onConfigChanged.forceEnable.
#681
Re-enable the functionality of file watcher since clangd's builtin restart functionality does not refresh opened files in vscode, leading to potentially misleading ifdef view