Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename image parameter names #378

Merged
merged 19 commits into from
Oct 18, 2024
Merged

Rename image parameter names #378

merged 19 commits into from
Oct 18, 2024

Conversation

haesleinhuepf
Copy link
Member

@haesleinhuepf haesleinhuepf commented Oct 17, 2024

Here I'm renaming some image parameters, where it appears crucial to me, e.g. if a parameter is a list of coordinates, it should not be called input_image.

Additionally, I added and corrected documentation in other cases.

partially addresses clEsperanto/pyclesperanto#260

@haesleinhuepf
Copy link
Member Author

Hey @StRigaud I'm running out of time. So here are coming the most important image parameter renamings + documentation upgrads for other functions where it seems important.

@StRigaud
Copy link
Member

I will have a look at the tests and see to fix it

clic/include/tier3.hpp Outdated Show resolved Hide resolved
@StRigaud
Copy link
Member

FYI, having the label as second parameter to the statistic function is really not convenient 😞

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 48.36%. Comparing base (a599c24) to head (745d875).

Files with missing lines Patch % Lines
clic/src/tier1/generate_distance_matrix.cpp 45.45% 0 Missing and 6 partials ⚠️
clic/src/tier1/multiply_matrix.cpp 50.00% 0 Missing and 2 partials ⚠️
clic/src/tier2/count_touching_neighbors.cpp 33.33% 0 Missing and 2 partials ⚠️
clic/src/tier4/centroids_of_labels.cpp 0.00% 1 Missing and 1 partial ⚠️
clic/src/tier6/voronoi_labeling.cpp 50.00% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   48.36%   48.36%           
=======================================
  Files         243      243           
  Lines        3974     3980    +6     
  Branches     1818     1822    +4     
=======================================
+ Hits         1922     1925    +3     
  Misses        619      619           
- Partials     1433     1436    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member

Works locally, will integrate it with a final release before I2K hopefully

@StRigaud StRigaud merged commit 4e8662d into master Oct 18, 2024
5 checks passed
@StRigaud StRigaud deleted the rename_image_parameter_names branch October 18, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants