-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename image parameter names #378
Conversation
for more information, see https://pre-commit.ci
…speranto/CLIc into rename_image_parameter_names
This reverts commit 639c526.
for more information, see https://pre-commit.ci
…speranto/CLIc into rename_image_parameter_names
Hey @StRigaud I'm running out of time. So here are coming the most important image parameter renamings + documentation upgrads for other functions where it seems important. |
I will have a look at the tests and see to fix it |
Signed-off-by: Stephane Rigaud <[email protected]>
FYI, having the label as second parameter to the statistic function is really not convenient 😞 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 48.36% 48.36%
=======================================
Files 243 243
Lines 3974 3980 +6
Branches 1818 1822 +4
=======================================
+ Hits 1922 1925 +3
Misses 619 619
- Partials 1433 1436 +3 ☔ View full report in Codecov by Sentry. |
Works locally, will integrate it with a final release before I2K hopefully |
Here I'm renaming some image parameters, where it appears crucial to me, e.g. if a parameter is a list of coordinates, it should not be called input_image.
Additionally, I added and corrected documentation in other cases.
partially addresses clEsperanto/pyclesperanto#260