Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated license terms docs based on content from ckeditor.com #17544

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

Reinmar
Copy link
Member

@Reinmar Reinmar commented Nov 27, 2024

Suggested merge commit message (convention)

Docs: Updated license terms docs based on content from ckeditor.com.


Additional information

I de-title-cased two titles.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 27, 2024

image

menu-title: Editor license
order: 30
modified_at: 2024-11-20
---

# Editor license and legal terms

The following legal notices apply to CKEditor 5 and all software from CKEditor 5 Ecosystem included with it.
CKEditor is dual-licensed. This means we make it available under a choice between an open source and a commercial license.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under a choice sounds a bit clunky, but I may be wrong, @godai78 could you check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This is straight from ckeditor.com new licensing page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not mean it is worded properly :D

I'd say "This means you can choose between..." cause this is simple and straightforward.

And I would update it on the new licensing page as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a ticket for ckeditor.com too.

* Export to Word
* Export to PDF
* Multi-level Lists
* Advanced Productivity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advanced productivity is not a name of our capability, where did it come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh....


Licensed under the terms of [GNU General Public License Version 2 or later](http://www.gnu.org/licenses/old-licenses/gpl-2.0.html).
The open source distribution of CKEditor is licensed under the terms of GPL 2+. If you plan to use CKEditor under this license, you can register your application using [the CKEditor GPL 2+ license registration form](https://info.ckeditor.com/l/1018062/2024-08-22/39jtg).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of times LanguageTool marked for me GPL license as This phrase is redundant (‘L’ stands for ‘license’). Use simply “GPL”. But I think it's quite common to use it this way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd stick to "GPL License" even if it's droll. People tend to understand better.

Witoso
Witoso previously approved these changes Nov 27, 2024
Copy link
Member

@Witoso Witoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few non-critical remarks/nitpicks, otherwise OK!

godai78
godai78 previously approved these changes Nov 27, 2024
Copy link
Contributor

@godai78 godai78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'd still advise changing the under choice phrase.

@arkflpc arkflpc merged commit 4fc7819 into release Nov 27, 2024
1 check passed
@arkflpc arkflpc deleted the updated-license-terms-docs branch November 27, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants