Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support partial indexing for rich-indexer #715

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

homura
Copy link
Collaborator

@homura homura commented Jun 20, 2024

Description

Resolves #656

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jun 20, 2024 9:41am

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 77.29730% with 42 lines in your changes missing coverage. Please review.

Project coverage is 87.37%. Comparing base (8d11c75) to head (36d5838).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #715      +/-   ##
===========================================
+ Coverage    85.67%   87.37%   +1.69%     
===========================================
  Files          131      131              
  Lines        25247    25455     +208     
  Branches      2663     2900     +237     
===========================================
+ Hits         21631    22241     +610     
+ Misses        3576     3175     -401     
+ Partials        40       39       -1     
Files Coverage Δ
packages/base/src/indexer.ts 85.77% <100.00%> (ø)
packages/ckb-indexer/src/resultFormatter.ts 82.35% <100.00%> (+0.72%) ⬆️
packages/ckb-indexer/src/type.ts 100.00% <100.00%> (ø)
packages/codec/src/bytes.ts 100.00% <100.00%> (+0.78%) ⬆️
packages/rpc/src/paramsFormatter.ts 86.36% <100.00%> (+2.87%) ⬆️
packages/ckb-indexer/src/services.ts 75.52% <70.00%> (-1.35%) ⬇️
packages/ckb-indexer/src/collector.ts 76.73% <73.68%> (-0.53%) ⬇️
packages/ckb-indexer/src/ckbIndexerFilter.ts 84.08% <29.16%> (-8.18%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d11c75...36d5838. Read the comment docs.

@homura homura changed the title feat(codec): added indexOf to search bytes feat: support partial indexing for rich-indexer Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the new rich indexer
1 participant