Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init PRD #342

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

init PRD #342

wants to merge 10 commits into from

Conversation

Sven-TBD
Copy link
Collaborator

Create a PRD file for the second demo

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #342 (870f87a) into develop (827221a) will decrease coverage by 6.11%.
Report is 76 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
- Coverage    68.13%   62.02%   -6.11%     
===========================================
  Files           87       94       +7     
  Lines         2617     3110     +493     
  Branches       587      690     +103     
===========================================
+ Hits          1783     1929     +146     
- Misses         755     1071     +316     
- Partials        79      110      +31     

see 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ed219...870f87a. Read the comment docs.

@Daryl-L
Copy link
Contributor

Daryl-L commented Jun 28, 2023

How about building a simple market in this tool. Users can not only manage the sUDTs, but also sell or buy sUDT in this simple market.

@Keith-CY
Copy link
Member

Keith-CY commented Jun 28, 2023

How about building a simple market in this tool. Users can not only manage the sUDTs, but also sell or buy sUDT in this simple market.

The demo is built to extend the tutorial https://docs.nervos.org/docs/labs/sudtbycapsule/ as a guide of the framework, not for finance-related activity.

Notice that developments in minting tokens, market are very sensitive from the regulatory perspective, and better to be avoided in a technical team.

This demo may include minting because it's an extension of the existing tutorial

@@ -0,0 +1,31 @@
# User Stories of the Second demo

> Notes: The requirements mentioned here is for some specific requirement which is considerred general and easy to understand. Developers can adjust/modify/rewrite the whole implement once he understand the framework of kuai.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Notes: The requirements mentioned here is for some specific requirement which is considerred general and easy to understand. Developers can adjust/modify/rewrite the whole implement once he understand the framework of kuai.
> Notes: The requirements mentioned here are for some specific requirements general and easy to understand. Developers can adjust/modify/rewrite the whole implementation once they understand the framework of kuai.


> Notes: The requirements mentioned here is for some specific requirement which is considerred general and easy to understand. Developers can adjust/modify/rewrite the whole implement once he understand the framework of kuai.

Second demo of Kuai is a sudt dapp which allows a Token Minter to create/mint/manage token and Holders to transfer token.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Second demo of Kuai is a sudt dapp which allows a Token Minter to create/mint/manage token and Holders to transfer token.
The second demo of Kuai is a sudt dapp which allows a Token Minter to mint/manage token and Holders to transfer token.

Comment on lines 9 to 11
- Token Minter: The one who mint the SUDT and are able to manage tokens he minted
- Token Holder: Users who have access to the Token, he can transfer
- Normal Users: Users who many just want to view some info of token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Token Minter: The one who mint the SUDT and are able to manage tokens he minted
- Token Holder: Users who have access to the Token, he can transfer
- Normal Users: Users who many just want to view some info of token
- Token Minter: The one who mints the SUDT and is able to manage tokens he/she minted
- Token Holder: Users who have access to the Token, he/she can transfer
- Normal Users: Users who may just want to view some info of token

Sven-TBD and others added 9 commits July 5, 2023 01:51
…tnet; 3.Disable the Mainnet option while choose network but remain mainet case;4. remove import token; 5.elaborate the History Tab on Root Page on the picture.
…- disable to switch to mainnet; -add whitelist description of the Token Tab usage; -Elabrate field on Histor Tab,undefined amount meaning and so on. This doc is ready for a finalization discussion.
Signed-off-by: SIYUAN ZHOU <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants