-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Handle umlaut in resource URLs #58
Open
metaodi
wants to merge
11
commits into
ckan:master
Choose a base branch
from
opendata-swiss:unicode-in-url
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metaodi
force-pushed
the
unicode-in-url
branch
from
November 7, 2018 12:26
20b1beb
to
b8d4ccd
Compare
metaodi
force-pushed
the
unicode-in-url
branch
from
November 7, 2018 12:56
b8d4ccd
to
3120e94
Compare
metaodi
force-pushed
the
unicode-in-url
branch
from
November 7, 2018 13:37
ff1d640
to
982773f
Compare
metaodi
force-pushed
the
unicode-in-url
branch
from
November 7, 2018 14:26
60ec367
to
e0d65e6
Compare
@metaodi This looks basically great - is there a reason it's still marked WIP? |
@davidread oh let me check and resolve the conflicts. No real reason other than changed priorities 😉 |
JVickery-TBS
pushed a commit
to JVickery-TBS/ckanext-xloader
that referenced
this pull request
Nov 8, 2023
Develop to master - fix overly aggressive date parsing
Is this still needed under Python 3? If so, @metaodi merge conflicts will need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #56, fix the encoding problem: