Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Handle umlaut in resource URLs #58

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

metaodi
Copy link
Member

@metaodi metaodi commented Nov 7, 2018

Related to #56, fix the encoding problem:

Traceback (most recent call last):
  File "/home/ckanuser/pyenv/bin/paster", line 11, in <module>
    sys.exit(run())
  File "/home/ckanuser/pyenv/lib/python2.7/site-packages/paste/script/command.py", line 102, in run
    invoke(command, command_name, options, args[1:])
  File "/home/ckanuser/pyenv/lib/python2.7/site-packages/paste/script/command.py", line 141, in invoke
    exit_code = runner.run(args)
  File "/home/ckanuser/pyenv/lib/python2.7/site-packages/paste/script/command.py", line 236, in run
    result = self.command()
  File "/home/ckanuser/web/ckanext/ckanext-xloader/ckanext/xloader/cli.py", line 74, in command
    self._submit_all()
  File "/home/ckanuser/web/ckanext/ckanext-xloader/ckanext/xloader/cli.py", line 145, in _submit_all
    self._submit_package(p_id, user, indent=2)
  File "/home/ckanuser/web/ckanext/ckanext-xloader/ckanext/xloader/cli.py", line 166, in _submit_package
    self._submit_resource(resource, user, indent=indent + 2)
  File "/home/ckanuser/web/ckanext/ckanext-xloader/ckanext/xloader/cli.py", line 190, in _submit_resource
    .format(dataset=dataset_ref, r=resource, indent=' ' * indent))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 83: ordinal not in range(128)

@davidread
Copy link
Contributor

@metaodi This looks basically great - is there a reason it's still marked WIP?

@metaodi
Copy link
Member Author

metaodi commented Nov 15, 2019

@davidread oh let me check and resolve the conflicts. No real reason other than changed priorities 😉

JVickery-TBS pushed a commit to JVickery-TBS/ckanext-xloader that referenced this pull request Nov 8, 2023
Develop to master - fix overly aggressive date parsing
@ThrawnCA
Copy link
Collaborator

Is this still needed under Python 3? If so, @metaodi merge conflicts will need to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants