Matlab/Octave: OCTAVE_VERSION instead of ver

[carandraug]

This is the recommended method to distinguish between Octave and Matlab.

ver returns a struct array, one element for Octave and another for each of the installed packages. It is not documented that the first element will be Octave. This method is also much simpler.

[cjlin1]

Many thanks. This will be updated in the next release.
Carnë Draug writes:

This is the recommended method to distinguish between Octave and Matlab.

ver returns a struct array, one element for Octave and another for each of the
installed packages. It is not documented that the first element will be Octave.
This method is also much simpler.

---

You can view, comment on, or merge this pull request online at:

#30

Commit Summary

• Matlab/Octave: use the standard method of checking OCTAVE_VERSION to
  distinguish between the two.

File Changes

• M matlab/make.m (3)

Patch Links:

• https://github.com/cjlin1/libsvm/pull/30.patch
• https://github.com/cjlin1/libsvm/pull/30.diff

—
Reply to this email directly or view it on GitHub.*

[infwinston]

@carandraug
"exist ("OCTAVE_VERSION", "builtin")" will not work for Matlab, since double quotation is invalid in Matlab.
I think it should be modified to "exist ('OCTAVE_VERSION', 'builtin')"?
Thanks.

[carandraug]

@infwinston you are absolutely right. I only test this in Octave and this is one of the things that always catches me my surprise.

I have force pushed a new commit with the right quotes for Matlab compatibility.