Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#357] Fixed link has invalid state #445

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

febdao
Copy link
Collaborator

@febdao febdao commented Dec 15, 2024

Ticket/issue:

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Fixed link has invalid state
  2. Updated menu test

Screenshots

Screenshot 2024-12-15 at 11 56 05 pm

@febdao febdao added the PR: Needs review Pull request needs a review from assigned developers label Dec 15, 2024
@febdao febdao requested a review from richardgaunt December 15, 2024 13:06
@febdao febdao self-assigned this Dec 15, 2024
Copy link

github-actions bot commented Dec 15, 2024

@github-actions github-actions bot temporarily deployed to pull request December 15, 2024 13:09 Inactive
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.17%. Comparing base (caf1cb1) to head (05feccc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   23.17%   23.17%           
=======================================
  Files          27       27           
  Lines        1312     1312           
  Branches      312      312           
=======================================
  Hits          304      304           
  Misses        812      812           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@febdao Thanks nice work

@richardgaunt richardgaunt added PR: CONFLICT Pull request has a conflict that needs to be resolved before it can be merged and removed PR: Needs review Pull request needs a review from assigned developers labels Dec 16, 2024
@febdao febdao added PR: Needs review Pull request needs a review from assigned developers and removed PR: CONFLICT Pull request has a conflict that needs to be resolved before it can be merged labels Dec 16, 2024
@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 11:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCAG 4.1.2 A: Link has invalid state (Issue 36)
2 participants