Do not add custom fields of custom groups with style other than "Inline" to forms where in the UI those fields are loaded via Ajax

[jensschuppe]

Fixes dev/core#5613

Prevent data loss for forms of non-Contact entities with custom groups of style other than Inline.

This fixes a regression for code that uses the style attribute in a way that can't be built through the UI (as it can't be set for other entities than Contact).

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

@jensschuppe if this is a regression then the PR should be against the 5.80 branch.

[jensschuppe]

Well, it depends … the scenario where this leads to data loss can't be built through the UI, so I can't judge.

[aydun]

That makes sense - the AJAX in CRM/common/customDataBlock.tpl only pulls in Inline so the related addCustomDataFieldsToForm() should do the same. style has to be set by API (other than Contacts) but you need some other mechanism to display those fields.

Looks good to me.

[jensschuppe]

Maybe @eileenmcnaughton should have a look, as the underlying problem got exposed with #30569 …?