Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#980 [test -dbunit] remove dbunit dependency from MembershipRenewalTest #14315

Merged
merged 1 commit into from
May 24, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 24, 2019

Overview

Removes dependency on discontinued dbunit package from MembershipRenewalTest

Before

dbunit used

After

dbunit not used

Technical Details

In local testing I get a failure running just this class. I ALSO get the failure without this change & believe it is UI replicable. I think this test has intermittent fails so may be related - will put up separate fix

Comments

See #14321

@civibot
Copy link

civibot bot commented May 24, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 can you merge this - should be a no-brainer

@seamuslee001
Copy link
Contributor

change seems to make sense as its test only Jenkins is the only checker here

@seamuslee001 seamuslee001 merged commit 4a7d5c5 into civicrm:master May 24, 2019
@seamuslee001 seamuslee001 deleted the dbunit_xml branch May 24, 2019 02:03
@eileenmcnaughton eileenmcnaughton changed the title [dbunit] remove dbunit dependency from MembershipRenewalTest dev/core#980 [test -dbunit] remove dbunit dependency from MembershipRenewalTest May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants