dev/core#980 [dbunit] QueryTest Remove dbunit dependency on discontinued dbunit #14283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
db_test3
branch
from
10be20c to
63910b8
Compare
eileenmcnaughton
force-pushed
the
db_test3
branch
from
63910b8 to
c69ecb1
Compare
colemanw
reviewed
May 22, 2019
| $op = new PHPUnit_Extensions_Database_Operation_Insert(); | ||
| $op->execute($this->_dbconn, | ||
| $this->createFlatXMLDataSet( | ||
| dirname(__FILE__) . '/queryDataset.xml' |
There was a problem hiding this comment.
if we're no longer using this file, should we remove it?
There was a problem hiding this comment.
Yep - I was gonna look at those at the end
|
Tests pass; by definition it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove dbunit from QueryTest
See #14321