dev/core#980 [test-dbunit] Cleanup profile test to not use discontinuted dbunit #14279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
db_test2
branch
2 times, most recently
from
88313fb to
d5f00ca
Compare
eileenmcnaughton
force-pushed
the
db_test2
branch
from
d5f00ca to
7f6a76d
Compare
|
@seamuslee001 can you merge this? |
|
Confirmed the changes match the dataset merging as test pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes reliance from ProfileTest class on discontinued dbunit package
Before
dbunit used to set up data
After
Api functions used
Technical Details
per #14321 dbunit is no longer supported. It also adds complexity managing phpunit version migration
Comments
https://lab.civicrm.org/dev/core/issues/980