Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scraper / geocoder from pvh #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pvanheus
Copy link
Collaborator

@pvanheus pvanheus commented Aug 1, 2020

Add the scripts and most supporting data for PvH's scraper.

@pvanheus
Copy link
Collaborator Author

pvanheus commented Aug 1, 2020

Missing data

The AfriGIS_Suburbs_Towns_List.csv is derived from proprietary data and is not included. Also address_test_set_pvh.txt and test_addresses.txt are restricted datasets and only the header line is included in this repository.

@Gordonei
Copy link
Contributor

Gordonei commented Aug 2, 2020

Thanks, @pvanheus - looks good to me. Illustrates nicely what you can do with just the batteries-included libs!

I don't think it makes sense to ask for any changes here - I'll just pull the branch down, and give it a whirl. Please let me know when you've uploaded the accompanying full data files (AfriGIS_Suburbs_Towns_List.csv, address_test_set_pvh.txt, test_addresses.txt, I think?) to the location we provided, and I'll give it a go.

@Gordonei
Copy link
Contributor

Just a bump @pvanheus - please will you upload the data files to the location we discussed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants