Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gh actions pipeline for build & test #136

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

gurkanindibay
Copy link

@gurkanindibay gurkanindibay commented Aug 26, 2022

TODO: After merging citusdata/tools#239 tools version should be updated with tag to be created

@hanefi
Copy link
Member

hanefi commented Aug 26, 2022

@gurkanindibay please request reviews after the tests pass and the implementation is complete.

Comment on lines 20 to 22
- 9.4
- 9.5
- 9.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PG versions are not supported anymore. We can drop them.

@gurkanindibay
Copy link
Author

@gurkanindibay please request reviews after the tests pass and the implementation is complete.

@hanefi there are compile and test errors. I've sent it to check and fix it. My main task is to add the pipeline not to fix the tests. If there are some parameters to add please notify me and I can add this param. But I think failures are not related to pipeline

@hanefi
Copy link
Member

hanefi commented Aug 26, 2022

I fixed one missing test change we missed when bumping 2.17, and removed the PostgreSQL versions that EOLd.

All that is missing is a development on tools repository for PG15 support. I have an open PR citusdata/tools#239 . Can we use that here? That PR is not tested enough, and some more work may be needed. I guess that is part of creating the pipeline. Can you take over that PR @gurkanindibay ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants