Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SetVehicleJetEngineOn -> SetVehicleKeepEngineOnWhenAbandoned #970

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

Scaarus
Copy link
Contributor

@Scaarus Scaarus commented Jan 1, 2024

This is a simple rename with an added description. Calling this native on any vehicle with toggle=true causes the engine of the vehicle to remain on even after exiting. Setting to false simply returns the vehicle to normal behavior.

Found this in the source code that's been floating around this past week and tested to ensure it works as expected.

Scaarus and others added 3 commits January 1, 2024 00:24
Slight nitpick regarding parameter descriptions and taking the description out of fenced blocks so it doesn't show as imported documentation from nativedb.
Grammar regarding vehicle parameter.
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made some slight nitpicks, that's all.
Thank you for your contribution!

@4mmonium 4mmonium merged commit d85bb74 into citizenfx:master Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants