Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs/natives): improve description #962

Merged
merged 7 commits into from
Apr 21, 2024

Conversation

PsychoShock
Copy link
Contributor

Still in progress. This PR will have a goal to review a lot of natives missing descriptions.

@spacevx
Copy link
Contributor

spacevx commented Dec 25, 2023

A maximum of 8 files can be changed (including adding or deleting files), as asked by @4mmonium, to make it easier to review

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, left you some feedback.
Here's the contribution guide for you to use as reference.
Merry Christmas by the way!

SYSTEM/Settimera.md Outdated Show resolved Hide resolved
SYSTEM/Settimerb.md Outdated Show resolved Hide resolved
PED/SetPedCombatRange.md Outdated Show resolved Hide resolved
@PsychoShock
Copy link
Contributor Author

PsychoShock commented Dec 25, 2023

Damn sorry that's a messy PR. Should be better now.

@PsychoShock
Copy link
Contributor Author

This PR should be good to review @4mmonium . Thanks.

PsychoShock and others added 6 commits January 24, 2024 21:12
Add `eCombatRange` enum.
Update parameter descriptions.
Complement the native's documentation.
Grammar nitpick.
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, merging! Thank you 😊

@4mmonium 4mmonium merged commit 4e7f89f into citizenfx:master Apr 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants