-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs/natives): improve description #962
Conversation
A maximum of 8 files can be changed (including adding or deleting files), as asked by @4mmonium, to make it easier to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, left you some feedback.
Here's the contribution guide for you to use as reference.
Merry Christmas by the way!
Damn sorry that's a messy PR. Should be better now. |
Better description.
This PR should be good to review @4mmonium . Thanks. |
Add `eCombatRange` enum.
Update parameter descriptions.
Complement the native's documentation.
Grammar nitpick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, merging! Thank you 😊
Still in progress. This PR will have a goal to review a lot of natives missing descriptions.