Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(natives): expand example and update natives for enhanced functio… #934

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat(natives): expand example and update natives for enhanced functio… #934

merged 2 commits into from
Nov 22, 2023

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Nov 19, 2023

  • Addition of usage examples for the DeleteEntity native in Lua, JavaScript, and C#.
  • Recommendation to use DoesEntityExist for proper entity existence validation before calling DeleteEntity.
  • Updates the name of the following natives:
    • _CLEAR_WEATHER_TYPE_OVERTIME_PERSIST
    • _GET_VEHICLE_DOOR_DESTROY_TYPE

4mmonium
4mmonium suggested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, a couple changes needed and it's good to go, check over what I commented.
Thank you for your contribution! 😊

@spacevx
Copy link
Contributor Author

spacevx commented Nov 22, 2023

Hey it's good!

@spacevx
Copy link
Contributor Author

spacevx commented Nov 22, 2023

Btw you can close #850 since it was the same

@spacevx spacevx requested a review from 4mmonium November 22, 2023 12:16
@4mmonium
Update ClearWeatherTypeNowPersistNetwork.md
af4d963 
Provide a usage example, remove wrongly assigned alias and rename the `milliseconds` parameter to `transitionTimeInMs`.
4mmonium
4mmonium approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I made some corrections to ClearWeatherTypeNowPersistNetwork.md and provided a usage example for it.

Thank you for your contribution 🎉

@4mmonium 4mmonium merged commit 58e12b6 into citizenfx:master Nov 22, 2023
1 check passed
@4mmonium 4mmonium mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4mmonium 4mmonium 4mmonium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spacevx @4mmonium