Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(natives/vehicles): Update natives about hover mode (deluxo/opres… #931

Merged
merged 3 commits into from
Nov 13, 2023
Merged

feat(natives/vehicles): Update natives about hover mode (deluxo/opres… #931

merged 3 commits into from
Nov 13, 2023

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Nov 7, 2023

The code provided in the examples has only been tested in Lua; there may be errors

@spacevx
Copy link
Contributor Author

spacevx commented Nov 7, 2023

So i don't know why the checks are failing :(

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for your contribution. I reviewed this PR, it's OK for the most part with a couple issues here and there, a couple changes and it's good to go 😀

We have a contribution guide if you want to check it out (CONTRIBUTING.md).

VEHICLE/SetSpecialFlightModeAllowed.md Outdated Show resolved Hide resolved
VEHICLE/SetDisableHoverModeFlight.md Outdated Show resolved Hide resolved
VEHICLE/SetSpecialFlightModeRatio.md Outdated Show resolved Hide resolved
VEHICLE/SetSpecialFlightModeAllowed.md Outdated Show resolved Hide resolved
@spacevx spacevx requested a review from 4mmonium November 7, 2023 17:35
@spacevx
Copy link
Contributor Author

spacevx commented Nov 9, 2023

@4mmonium I made all the requested changes

Remove double hashes (`##`) since that's reserved for native parameters/example headers.
Remove double hashes (`##`) since that's reserved for native parameters/example headers, also add a new line between the native `c` declaration and its description.
@4mmonium
Copy link
Contributor

@thorium-cfx This changes a couple native file names and adds aliases (I'm pretty sure it's fine), but I assigned this to you to make sure, thanks!

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to your PR, check the commits, they mostly involved the double hash usage that is reserved for example and parameters (custom headers using double slashes are not allowed, one may use triple hashes instead). I cannot approve this yet, but good job nonetheless! 😊

@thorium-cfx
Copy link
Contributor

@thorium-cfx This changes a couple native file names and adds aliases (I'm pretty sure it's fine), but I assigned this to you to make sure, thanks!

Aliased: check.
Same parameters: check.
LGTM

Would be even nicer if these files can be marked as moved, probably need to do it with git directly in this case.

@thorium-cfx thorium-cfx assigned 4mmonium and unassigned thorium-cfx Nov 13, 2023
@4mmonium 4mmonium merged commit cdfdfb5 into citizenfx:master Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants