-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(natives/vehicles): Update natives about hover mode (deluxo/opres… #931
Conversation
So i don't know why the checks are failing :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for your contribution. I reviewed this PR, it's OK for the most part with a couple issues here and there, a couple changes and it's good to go 😀
We have a contribution guide if you want to check it out (CONTRIBUTING.md).
@4mmonium I made all the requested changes |
Remove double hashes (`##`) since that's reserved for native parameters/example headers.
Remove double hashes (`##`) since that's reserved for native parameters/example headers, also add a new line between the native `c` declaration and its description.
@thorium-cfx This changes a couple native file names and adds aliases (I'm pretty sure it's fine), but I assigned this to you to make sure, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes to your PR, check the commits, they mostly involved the double hash usage that is reserved for example and parameters (custom headers using double slashes are not allowed, one may use triple hashes instead). I cannot approve this yet, but good job nonetheless! 😊
Aliased: check. Would be even nicer if these files can be marked as moved, probably need to do it with |
The code provided in the examples has only been tested in Lua; there may be errors