Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-university-for-the-creative-arts.csl #7346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ibadger
Copy link
Contributor

@ibadger ibadger commented Dec 4, 2024

This change is to do with Directors in the CSL. Zotero is using CSL 1.0.2 and uses the Director variable and tag, this doesn't display at the moment in our current CSL when referencing with Zotero. I made a commit in the summer but withdrew it as the changes suggested by the reviewer had a knock on impact, as I've since discovered that other software that students use at UCA (Paperpile, BibGuru, myBib) don't currently use CSL 1.0.2. and won't display the director or tag if I update the code as was suggested.

Would it be possible to approve this commit, where the code will display either director or author and use a prefix instead of a label?

"The "Director" name variable was introduced last year with CSL 1.0.2. Therefore, a lot of citation styles don't include it yet."

From https://forums.zotero.org/discussion/comment/476797/#Comment_476797

This change is to do with Directors in the CSL. Zotero is using CSL 1.0.2 and uses the Director variable and tag, this doesn't display at the moment in our current CSL when referencing with Zotero. I made a commit in the summer but withdrew it as the changes suggested by the reviewer had a knock on impact, as I've since discovered that other software that students use at UCA (Paperpile, BibGuru, myBib) don't currently use CSL 1.0.2. and won't display the director or tag if I update the code as was suggested.

Would it be possible to approve this commit, where the code will display either director or author and use a prefix instead of a label?

"The "Director" name variable was introduced last year with CSL 1.0.2. Therefore, a lot of citation styles don't include it yet."

From <https://forums.zotero.org/discussion/comment/476797/#Comment_476797>
Copy link

github-actions bot commented Dec 4, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@ibadger
Copy link
Contributor Author

ibadger commented Dec 4, 2024

Hi
It worked on the https://validator.citationstyles.org/ webpage, but I am getting a 'Process completed with exit code 1.' error

Any advice on what to do would be greatly appreciated

Best wishes

Ian

@adam3smith
Copy link
Member

CI is currently broken -- please ignore the failure

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants