Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/acet643 #3457

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Feature/acet643 #3457

merged 3 commits into from
Aug 14, 2023

Conversation

mattrwins
Copy link
Contributor

🗣 Description

Lets questionIcon behavior be missing for modules. Previously was crashing when guidanceIcon was checked.
Because of the code change, the ACET questionIcon behavior isn't needed anymore, so it was removed.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Marcus-Goectau Marcus-Goectau merged commit 3178e0d into develop Aug 14, 2023
2 checks passed
@Marcus-Goectau Marcus-Goectau deleted the feature/acet643 branch August 14, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants