Remove extraneous SHALL from MS.DEFENDER.4.1 #1408
Open
+33
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
The Defender SCB policy MS.DEFENDER.4.1v1 was reworded without changing the policy meaning so that it contains a single SHALL statement rather than two SHALLs for clarity. In addition, since the policy language was changed, the policy ID was incremented from v1 to v2. Policy version updates were made to the following:
💭 Motivation and context
Baselines should contain a single SHALL/SHOULD statement per policy so that a single testable policy item is associated with each statement and to prevent confusion among readers.
Closes #1385
🧪 Testing
To verify that all appropriate references have been updated:
Invoke-Scuba -p defender
to confirm proper HTML generation and review all automated test results.✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist