Update Rel8 to work with Opaleye's #586 #305
Conversation
| countRows = aggregate countStar | ||
| countRows = aggregate countStar . (true <$) |
There was a problem hiding this comment.
I'm curious about why this change is needed. What's going on here?
There was a problem hiding this comment.
It makes me concerned that there's some implication of the corresponding Opaleye change that I'm not aware of.
There was a problem hiding this comment.
Oh, maybe it's just to get a Table Expr i instance? If so then that's fine. (I was worried that there was some subtlety about the SQL that we generate, and this change was to avoid a crashing query.)
There was a problem hiding this comment.
I imagine it's to avoid propagating that constraint
There was a problem hiding this comment.
Great, that's reassuring. If so then there's nothing I don't understand and my PR is ready to go Opaleye-side. @duairc, could you please confirm?
There was a problem hiding this comment.
Apologies for the delay, but yes I can confirm that this is just to get a Table Expr instance.
shane-circuithub
force-pushed
the
aggregate-unpackspec
branch
from
3b099ff to
b6e8126
Compare
shane-circuithub
force-pushed
the
aggregate-unpackspec
branch
from
b6e8126 to
ecc1ce1
Compare
No description provided.