Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.0.0 #298

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Release 1.5.0.0 #298

merged 5 commits into from
Mar 19, 2024

Conversation

ocharles
Copy link
Contributor

@ocharles ocharles commented Dec 5, 2023

Fixes #293 and #288.

@ocharles ocharles force-pushed the push-wkzrnuyznuok branch 4 times, most recently from c5908a3 to 5e9e38d Compare December 5, 2023 12:31
@ocharles
Copy link
Contributor Author

ocharles commented Dec 5, 2023

@shane-circuithub I see that at CircuitHub we're also running #284. Shall we call that tested and also merge that into this release?

@ocharles
Copy link
Contributor Author

ocharles commented Dec 5, 2023

I would also like to see this build with all outdated deps: https://packdeps.haskellers.com/feed?needle=rel8

@ocharles
Copy link
Contributor Author

ocharles commented Dec 7, 2023

Ok, upstream deps aren't ready for 9.8, so the only outdated dep we need to address is Opaleye, which is already fixed in master. I think we're good to go!

@ocharles ocharles marked this pull request as ready for review December 7, 2023 18:50
@shane-circuithub
Copy link
Contributor

Hey, I merged the outstanding PRs that we're using in CircuitHub so this is nearly good to go now (though assuming the changelog is autogenerated from the scriv stuff you might want to regenerate that now that those PRs are in). The only remaining issue is that ordered set aggregation functions won't quite work until this fix to Opaleye is in. It's your call whether we wait for that to merge before releasing or not.

@shane-circuithub
Copy link
Contributor

Do note that the "aggregation" section of the cookbook is completely wrong though, it dates from the time we had an Apply interface for Aggregate, before the first release. It's even more wrong now with the changes made to aggregation in this release. Maybe we should fix that?

@ocharles
Copy link
Contributor Author

@shane-circuithub sorry for the delayed reply! I don't see a need to release ASAP, so I think we should wait for the Opaleye changes to land first.

@sir4ur0n
Copy link

What is the status of the 1.5.0.0 release please?
The latest comment suggests this is waiting for #298 to be merged and released, however this PR is closed, not merged.

On my project, we are waiting for some features present on master but not in a released version (most notably, the loop function, equivalent of WITH RECURSIVE), so I would like to check this releasing PR is not in some sort of deadlock 😁

@ocharles
Copy link
Contributor Author

Unfortunately just waiting on me to find the time to get the release out! Thanks for the nudge, I'll try and give this some more time soon

@ocharles ocharles force-pushed the push-wkzrnuyznuok branch from 61737e8 to 01a9fad Compare March 18, 2024 10:40
@ocharles ocharles force-pushed the push-wkzrnuyznuok branch from 01a9fad to 31ffccf Compare March 18, 2024 10:48
@ocharles ocharles enabled auto-merge (squash) March 19, 2024 14:45
@ocharles ocharles merged commit 4c18447 into master Mar 19, 2024
2 checks passed
@ocharles ocharles deleted the push-wkzrnuyznuok branch March 19, 2024 14:48
@sir4ur0n
Copy link

Awesome, thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Hackage release?
3 participants