Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Sql DBEq a
constraint on the return type of the aggregator was wrong. It also isn't quite right to have aEqTable i
constraint on the input type of theAggregator
, because technically what we want is aSql DBEq
constraint on whichever column(s) withini
are used by aggregation functions, but we don't know which columns were used at this point. We could givedistinctAggregate
a type likeSql DBEq i => Aggregator (Expr i) a
and make people run it throughlmap
manually, but that makes it impractical to use withListTable
without exposing more machinery. So we just drop the equality constraint for now.