rebased from rizkybiz/circonus-irondb-datasource.git b64-fixes-final #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 1, 2021 14:22
ewilhelm
commented
Sep 1, 2021
| @@ -546,7 +534,7 @@ export default class IrondbDatasource extends DataSourceApi<IrondbQueryInterface | |||
| return this.irondbType === 'standalone' ? '/' + this.accountId : ''; | |||
| } | |||
|
|
|||
| metricTagsQuery(query: string, allowEmptyWildcard = false, from?: number = null, to?: number = null) { | |||
| metricTagsQuery(query: string, allowEmptyWildcard = false, from: number = null, to: number = null) { | |||
There was a problem hiding this comment.
might not want or need this change
ewilhelm
commented
Sep 1, 2021
Comment on lines
+479
to
-493
| } else { | ||
| return value.join(','); | ||
| } | ||
|
|
||
| if (value.length === 1) { | ||
| return value[0]; | ||
| } | ||
|
|
||
| let q = ''; | ||
| for (let i = 0; i < value.length; i++) { | ||
| if (i > 0) { | ||
| q = q + ','; | ||
| } | ||
| q = q + value[i]; | ||
| i = i + 1; | ||
| } | ||
| return q; |
There was a problem hiding this comment.
this change is just replacing a longhand form of value.join(',')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #28 - not certain that it is complete / correct. There were many merge conflicts which appear to be related to the linting more than the base64 fixes.
Might not be a bad idea to start a fresh branch and just do the stuff in this one commit
fc4d307 plus perhaps something else from the original pass #27
It looks like b67d364 and 3e28302 (+ maybe a5316c1) are the bulk of the feature/bugfix here. These should have been squashed together and everything else should have been a separate branch of cleanup and linter fixes only.