Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix imageUrl in Image module to generate images from picsum photos #990 #998

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: fix imageUrl in Image module to generate images from picsum photos #990 #998

merged 3 commits into from
Nov 25, 2024

Conversation

bitalec
Copy link
Contributor

@bitalec bitalec commented Nov 25, 2024

Summary of changes:

  • Added a new method urlPicsumPhotos() to generate random images from the https://picsum.photos website.
  • Created necessary tests to ensure proper functionality.
  • Renamed the imageUrl() method in urlLoremFlickr() to better distinguish between the different websites used for image generation.

@bitalec bitalec changed the title fix: fix imageUrl in Image module to generate images from picsum photos #990 fix: fix imageUrl in Image module to generate images from picsum photos #990 Nov 25, 2024
@bitalec bitalec changed the title fix: fix imageUrl in Image module to generate images from picsum photos #990 fix: fix imageUrl in Image module to generate images from picsum photos #990 Nov 25, 2024
cieslarmichal
cieslarmichal requested changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, one comment

include/faker-cxx/image.h Show resolved Hide resolved
@cieslarmichal cieslarmichal mentioned this pull request Nov 25, 2024
Closed
@cieslarmichal cieslarmichal linked an issue Nov 25, 2024 that may be closed by this pull request
fix imageUrl in Image module to generate images from picsum photos #990
Closed
@bitalec bitalec changed the title fix: fix imageUrl in Image module to generate images from picsum photos #990 fix : fix imageUrl in Image module to generate images from picsum photos #990 Nov 25, 2024
@bitalec bitalec changed the title fix : fix imageUrl in Image module to generate images from picsum photos #990 fix: fix imageUrl in Image module to generate images from picsum photos #990 Nov 25, 2024
@cieslarmichal
Copy link
Owner

Please run clang format

@bitalec
Copy link
Contributor Author

bitalec commented Nov 25, 2024

Sorry, i think clang format is run now

@cieslarmichal cieslarmichal merged commit 9b7d709 into cieslarmichal:main Nov 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cieslarmichal cieslarmichal cieslarmichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix imageUrl in Image module to generate images from picsum photos
2 participants
@bitalec @cieslarmichal