Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Portugal location data #968

Merged
merged 8 commits into from
Oct 24, 2024
Merged

feat: Added Portugal location data #968

merged 8 commits into from
Oct 24, 2024

Conversation

tskxz
Copy link
Contributor

@tskxz tskxz commented Oct 23, 2024

As referred to in this issue #444 , I added Portugal location data.

cieslarmichal
cieslarmichal requested changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add portugal data to tests also to switch case function

@cieslarmichal cieslarmichal linked an issue Oct 23, 2024 that may be closed by this pull request
Add location addresses data from Portugal #444
Closed
@tskxz
Update location_test.cpp
3b912f5 
add portugal data to switch case
@tskxz tskxz requested a review from cieslarmichal October 23, 2024 20:49
@cieslarmichal cieslarmichal merged commit e730d22 into cieslarmichal:main Oct 24, 2024
12 checks passed
@tskxz tskxz deleted the feature/portugal-address branch October 24, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cieslarmichal cieslarmichal Awaiting requested review from cieslarmichal

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add location addresses data from Portugal
2 participants
@tskxz @cieslarmichal