Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create e-sport module (#768) #870

Merged
merged 2 commits into from
Aug 23, 2024
Merged

feat: create e-sport module (#768) #870

merged 2 commits into from
Aug 23, 2024

Conversation

dubloom
Copy link
Contributor

@dubloom dubloom commented Aug 23, 2024

Add a new e-sport module with the following methods:

  • std::string_view player();
  • std::string_view team();
  • std::string_view league();
  • std::string_view event();
  • std::string_view game();

@dubloom dubloom changed the title feat: create e-sport module feat: create e-sport module (#768) Aug 23, 2024
@cieslarmichal cieslarmichal linked an issue Aug 23, 2024 that may be closed by this pull request
create e-sport module #768
Closed
cieslarmichal
cieslarmichal approved these changes Aug 23, 2024
View reviewed changes
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good! 🔥

@cieslarmichal cieslarmichal merged commit 2d63faf into cieslarmichal:main Aug 23, 2024
13 checks passed
00thirdeye00 pushed a commit to 00thirdeye00/faker-cxx that referenced this pull request Aug 28, 2024
@dubloom @00thirdeye00
feat: create e-sport module (cieslarmichal#870)
ea8d6cf 
Co-authored-by: Louis Tricot <[email protected]>
00thirdeye00 pushed a commit to 00thirdeye00/faker-cxx that referenced this pull request Aug 28, 2024
@dubloom @00thirdeye00
feat: create e-sport module (cieslarmichal#870)
7d7dcff 
Co-authored-by: Louis Tricot <[email protected]>
cieslarmichal pushed a commit that referenced this pull request Aug 28, 2024
@00thirdeye00 @dubloom
refactor: sex function in person module (#872)
8e0c53e 
* feat: create e-sport module (#870)

Co-authored-by: Louis Tricot <[email protected]>

* feat: create video module (#871)

Co-authored-by: Louis Tricot <[email protected]>

* refactor: sex function in person module

* sex function modified to take locale as parameter
* modified function description for documentation
* removed unnecessary test functions and test suites

Signed-off-by: Guru Mehar Rachaputi <[email protected]>

---------

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
Co-authored-by: DoubleTricot <[email protected]>
Co-authored-by: Louis Tricot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cieslarmichal cieslarmichal cieslarmichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create e-sport module
2 participants
@dubloom @cieslarmichal