fix: arrayElement overloads failing with non-arithmetic iterators #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Algo seems to be passing over range twice... |
cieslarmichal
approved these changes
Aug 1, 2024
|
No, I was gonna say the algo was multi-passing and being inefficient, there's a single pass algorithm that's more elegant here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrayElement(start, end)overloads would fail when being used with bidrectional iterators or basically anything that wasnt arandom_access_iterator, so I added overloads for bothrandom_access_iterator's and every other form.Since random_access supports arithmetic we can just access index, but since every other iterator doesn't support we need to hand roll to the index.
Even before I rewrote the function yesterday it still would've failed on
listcontainers or non-random_access iterators.