fix: Made range arrayFormat overload more elegant + minor fixes #837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on latest GCC version and
ubuntu 22.04
I was getting conversion warnings fromarrayFormat(start, end)
overload specifically when used withsortedSizeArrayElement
inword_test.cpp
Primary Warnings thrown:
In instantiation of function template specialization 'faker::word::sortedSizeArrayElement<__gnu_cxx::__normal_iterator<std::basic_string *, std::vector<std::basic_string>>>' /home/eric/github/faker-cxx/include/faker-cxx/helper.h:64:18: warning: implicit conversion changes signedness: 'unsigned long const' to '__gnu_cxx::__normal_iterator<std::basic_string *, std::vector<std::basic_string>>::difference_type' (aka 'long')
Fixed
arrayFormat
to enforceinput_iterator
concept in templates and fixed implicit conversion in index return of the function.Cleaned up
boolean(probability)
ofdatatype.cpp
if (probability != nan(""))
now usesstd::isnan
function