chore: Added new e-sport module to be implemented (#768) #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehdibenhadjkhelifa
force-pushed
the
feature/module-esport
branch
from
91a1dc7 to
44bb25c
Compare
cieslarmichal
requested changes
Jul 4, 2024
Closed
cieslarmichal
requested changes
Jul 5, 2024
|
hey are you working on this or should I close a PR? |
|
Hey, I'm not currently working on it no. if someone else wants to take the job let them have it. |
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the e-sport module boilerplate code as requested. Although i don't know if the implementations were part of the request . Also changed cmake under /src to include both .cpp and .h files. If more work regarding this task is needed just let me know. Cheers !
Edit: Checks failed, probably because i forgot to export the functions and include them in the /include directory. I'm working on it.