refactor: moved unwanted public functions from Helper.h (#766) #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved all the functions that aren't needed to be visible via the header file helper.h to a the AlgoHelper.h file under src/common while fixing all other cpp files dependent on those function also changed the cmake file under src/ to include the AlgoHelper.h file too. This was tested to be functional using the UT provided by the project ( faker-cxx-UT) all tests passed. Also used clang-format on most of the files (forgot some) that i have changed whilst working in this refactoring as prescribed in the CONTRIBUTING.md file. Hope this helped ! Cheers !