Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stringhelper module #765

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

00thirdeye00
Copy link
Contributor

  • stringhelper module migration from class to functions within common namespace

  • modified reference to functions and variables from stringhelper module in all dependent modules

#755

- stringhelper module migration from class to functions within common namespace

- modified reference to functions and variables from stringhelper module in all dependent modules

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faker::common::StringHelper -> faker::common

@cieslarmichal cieslarmichal linked an issue Jul 1, 2024 that may be closed by this pull request
- stringhelper module namespace changed from "common::stringhelper" to
  "common"

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
@00thirdeye00
Copy link
Contributor Author

fixed

@cieslarmichal cieslarmichal merged commit 84e767b into cieslarmichal:main Jul 1, 2024
15 checks passed
@00thirdeye00 00thirdeye00 deleted the strhelp_ns_migrate branch August 16, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate StringHelper class to namespace common
2 participants