Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: number module migrate #730

Merged
merged 3 commits into from
Jun 25, 2024
Merged

refactor: number module migrate #730

merged 3 commits into from
Jun 25, 2024

Conversation

00thirdeye00
Copy link
Contributor

  • number module migration from class to functions within phone namespace

  • modified reference to functions from number module in all dependent modules

#680

@00thirdeye00
refactor: number module migrate
e139df3 
- number module migration from class to functions within phone namespace

- modified reference to functions from number module in all dependent modules

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal
cieslarmichal requested changes Jun 25, 2024
View reviewed changes
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all faker prefix example faker::number::integer to number::integer where applicable - all functions are inside faker namespace so it should work fine

include/faker-cxx/Helper.h Outdated Show resolved Hide resolved
@cieslarmichal cieslarmichal linked an issue Jun 25, 2024 that may be closed by this pull request
migrate Number module from class to functions within number namespace #680
Closed
@cieslarmichal cieslarmichal merged commit 13d94a3 into cieslarmichal:main Jun 25, 2024
10 checks passed
@00thirdeye00 00thirdeye00 deleted the num_ns_migrate branch August 16, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cieslarmichal cieslarmichal cieslarmichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate Number module from class to functions within number namespace
2 participants
@00thirdeye00 @cieslarmichal