refactor: sport module migrate (#684) #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sport module migration from class to functions within sport namespace Signed-off-by: Guru Mehar Rachaputi <[email protected]>
|
@cieslarmichal Please check out the discord general channel for this merge :) |
cieslarmichal
requested changes
Jun 24, 2024
Changed sport() function to sportName()
Changed sport() to sportName()
Changed "Sport" namespace to lowercase "sport"
Change sport() to sportName() and "Sport" to lowercase "sport" in sport namespace
cieslarmichal
requested changes
Jun 24, 2024
1. sport module migration from class to functions within sport namespace 2. changed function name from sport() to sportName() 3. changelog updated Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sport module migration from class to functions within sport namespace