Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply clang-tidy fix for misc-clean-include #621

Conversation

uilianries
Copy link
Contributor

I just started to run clang-tidy and resulted in tons of warnings, so I decided to split some fixes instead of pushing everything at once, so anyone can review much easier.

This time I executed in Linux:

cmake -S . --preset unixlike-clang-debug -DBUILD_TESTING:BOOL=ON -DCMAKE_CXX_CLANG_TIDY=clang-tidy-18
cmake --build --preset unixlike-clang-debug
run-clang-tidy-18 -p build/unixlike-gcc-debug/ -checks="misc-include-cleaner" -fix

The is including what we use for each file, which means, we use std::array but actually we import from a header that's using it. It's a fragile situation, any change could result in compilation error.

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 😎

@cieslarmichal cieslarmichal merged commit b0606de into cieslarmichal:main Jun 1, 2024
5 of 6 checks passed
00thirdeye00 pushed a commit to 00thirdeye00/faker-cxx that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants