Refactor word module #610
Closed
Refactor word module #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cieslarmichal
requested changes
May 31, 2024
| @@ -76,6 +76,7 @@ set(FAKER_SOURCES | |||
| src/modules/videoGame/VideoGameData.cpp | |||
| src/modules/weather/Weather.cpp | |||
| src/modules/word/Word.cpp | |||
| src/modules/word/wordData.cpp | |||
There was a problem hiding this comment.
source file name should start with upper case - WordData.cpp
| * @note This function is used internally, as a helper | ||
| * and it is not intended to be used by the user. | ||
| */ | ||
| static std::vector<std::string_view> createAllWords(); |
There was a problem hiding this comment.
move to cpp file, it is implementation detail - should not be in API file
| @@ -42,7 +42,7 @@ std::string extension(const std::string& mimeType) | |||
|
|
|||
| std::string System::fileName(const FileOptions& options) | |||
| { | |||
| std::string baseName = Word::words(); | |||
| std::string baseName = std::string(Word::words()); // Konwersja std::string_view na std::string | |||
| @@ -23,6 +22,7 @@ | |||
|
|
|||
| using namespace ::testing; | |||
| using namespace faker; | |||
| using namespace Words; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the word module and modified the tests to work with it.
Reopening because I accidentally closed old one