Add support for CMake presets #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
cieslarmichal
approved these changes
May 28, 2024
00thirdeye00
pushed a commit
to 00thirdeye00/faker-cxx
that referenced
this pull request
Jun 20, 2024
* Use CMake presets Signed-off-by: Uilian Ries <[email protected]> * Build debug Signed-off-by: Uilian Ries <[email protected]> * Add msvc toolset Signed-off-by: Uilian Ries <[email protected]> * remove explicit cl.exe Signed-off-by: Uilian Ries <[email protected]> * Use msvc generator Signed-off-by: Uilian Ries <[email protected]> * configure cl in path Signed-off-by: Uilian Ries <[email protected]> * fix preset name Signed-off-by: Uilian Ries <[email protected]> * fix preset name Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake presets is an useful feature to avoid passing a bunch of parameters when building the project, instead, only need the preset name.
As result, we can simplify the CI by a lot, running only few commands and not managing folders anymore.
Plus, I was able to run Ninja in Windows build, which is faster than regular Visual Studio generator.
TODO: Update documentation in order to explain how to use CMake preset with faker-cxx