Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple tests from sources #549

Merged
merged 6 commits into from
May 24, 2024

Conversation

uilianries
Copy link
Contributor

This PR moves all files related to testing to a new folder tests, giving a better control over the project.

  • The folder tests has a new CMakeLists.txt, which uses the previous content from main CMakeListst.txt
  • Remove the option BUILD_FAKER_TESTS in order to use the native CMake option BUILD_TESTING
  • Simplified CMakeLists.txt to only add tests in case BUILD_TESTING=ON
  • Updated header paths in test files to include absolute paths only
  • Fixed MSVC CI to use Env build type always

Tested locally on macOS with Apple Clang 15

Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
@cieslarmichal cieslarmichal merged commit c0f1562 into cieslarmichal:main May 24, 2024
6 checks passed
00thirdeye00 pushed a commit to 00thirdeye00/faker-cxx that referenced this pull request Jun 20, 2024
* Move few test files

Signed-off-by: Uilian Ries <[email protected]>

* Move more test files

Signed-off-by: Uilian Ries <[email protected]>

* Move test section to test cmake

Signed-off-by: Uilian Ries <[email protected]>

* update imported files

Signed-off-by: Uilian Ries <[email protected]>

* fix video game import name

Signed-off-by: Uilian Ries <[email protected]>

* Run tests on Linux Clang

Signed-off-by: Uilian Ries <[email protected]>

---------

Signed-off-by: Uilian Ries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants