-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external dependencies option #547
Add external dependencies option #547
Conversation
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Signed-off-by: Uilian Ries <[email protected]>
@cieslarmichal The current error is due -Werror with unused variable:
Not sure what best approach here, it could ignore Werror (remove from CMake), ignore that specific error (add pragma in String.cpp), or fixing it in the code (I don't know should be fixed in that case. |
I think we can disable werror flag. |
Signed-off-by: Uilian Ries <[email protected]>
@cieslarmichal Done, without -Werror everything passed. |
* Add external dependencies option Signed-off-by: Uilian Ries <[email protected]> * Add entry documenation to explain option Signed-off-by: Uilian Ries <[email protected]> * Add build for external dependencies Signed-off-by: Uilian Ries <[email protected]> * build on feature branch Signed-off-by: Uilian Ries <[email protected]> * Use Ubuntu 24.04 Signed-off-by: Uilian Ries <[email protected]> * Use python setup Signed-off-by: Uilian Ries <[email protected]> * fix conan install Signed-off-by: Uilian Ries <[email protected]> * Use std format only when no deps Signed-off-by: Uilian Ries <[email protected]> * No werror Signed-off-by: Uilian Ries <[email protected]> * Add Werror Signed-off-by: Uilian Ries <[email protected]> * Use compile options Signed-off-by: Uilian Ries <[email protected]> * Pass msvc flags Signed-off-by: Uilian Ries <[email protected]> * Drop -Werror Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]>
Add support to use external dependencies instead of vendorized ones. The new CMake option
USE_SYSTEM_DEPENDENCIES
, usesfind_package
to include (mandatory) fmt and gtest. In case that option is enabled, and the compiler has std::format supported, CMake will use the external dependencies, because the user configured it explicitly.Added a new CI job to validate the configuration.
closes #546