Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for vcpkg #537

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

mostsignificant
Copy link
Contributor

Changes for preparation for vcpkg added, but:

  • On MacOS X you still need to pull in fmt as extra
  • C++20 does not propagate as requirement, maybe somebody can add some target_compile_features magic
  • it will be includable via vcpkg (as soon as I make the PR there) via a namespace'd lib: faker-cxx::fakercxx, maybe to be considered for the faker-cxx project include, too

Please review and feedback, thanks!

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cieslarmichal cieslarmichal merged commit 266142b into cieslarmichal:main May 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants