Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new functions to book module #486

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

eric-bodhi
Copy link
Contributor

Added following functions

  • series
  • page
  • translator
  • releaseYear
  • format

Added following functions
- series
- page
- translator
- releaseYear
- format
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, minor comments

include/faker-cxx/Book.h Outdated Show resolved Hide resolved
include/faker-cxx/Book.h Outdated Show resolved Hide resolved
changed releaseYear function return type from std::string to int
removed bookFormat struct and changed format function data type to string
@cieslarmichal cieslarmichal merged commit fdefa78 into cieslarmichal:main Jan 21, 2024
4 checks passed
@eric-bodhi eric-bodhi deleted the feature/Book branch August 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants