Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Structure module (json, csv) #386

Merged
merged 4 commits into from
Dec 26, 2023

Conversation

alisedighmoghadam
Copy link
Contributor

This pull request introduces the new Structure Module, designed to address the requirements and objectives outlined in Issue #246.

@cieslarmichal please review the changes and provide your insights or approval.

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, couple of things to change :)

.gitmodules Outdated Show resolved Hide resolved
include/faker-cxx/Structure.h Outdated Show resolved Hide resolved
include/faker-cxx/Structure.h Outdated Show resolved Hide resolved
include/faker-cxx/Structure.h Outdated Show resolved Hide resolved
include/faker-cxx/Structure.h Outdated Show resolved Hide resolved
src/common/JsonHelper.h Outdated Show resolved Hide resolved
@cieslarmichal cieslarmichal linked an issue Dec 25, 2023 that may be closed by this pull request
@cieslarmichal
Copy link
Owner

Nice, good job :)

@cieslarmichal cieslarmichal merged commit 0ba0d4b into cieslarmichal:main Dec 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Structure module (json, csv)
2 participants